[news.software.b] AARGH! 2.11 update #2 requires -S with -U

david@ukma.UUCP (12/29/86)

hmmm... the subject line says it all.  I've applied update #2 and
"rnews -U" suddenly stopped unbatching ... Examining the source code I
find that we're required to specify -S now (in contradiction to the
manual page for inews which says "It should never be specified directly
(It is normally used by rnews -U)."  (BTW, the manual page has a
missing ")" at this point).

Here is an editted version of the relavent code from inews.c:

	actfp = xfopen(ACTIVE, "r+");
	if (we can't lock ACTIVE)
		spool_news = TRUE;
	else {
		if (argc > 1 && !strcmp(*(argv+1), "-S")) {
			argc--;
			argv++;
		} else
			spool_news = TRUE;
	}
	if (argc > 1 && !strcmp(*(argv+1), "-U")) {
              if (spool_news) /* can't unspool while things are locked */
                      xxit(0);
		dounspool();
		/* NOT REACHED */
	}

In order to dounspool() you MUST specify "-S -U" ... I don't think
this is what was meant... 

Oh, notice that the -S must be the first argument and the -U the
second.  I was under the impression that this sort of thing
_was_not_to_happen_ when using getopt()?
-- 
David Herron,  cbosgd!ukma!david, david@UKMA.BITNET, david@ms.uky.csnet
(I'm also "postmaster", "news", "netnews", "uucp", "mmdf", and ...)

"Don't put your money in South Africa -- Give it to me!" -- Cerebus