[news.software.b] fseek in 4.1BSD broken, watch out!

sater@cs.vu.nl (Hans van Staveren) (01/05/88)

I noticed that on our poor 4.1BSD Vax750's the code to change
from moderated to unmoderated and vice versa did not work reliably.
After a lot of painful debugging I found that fseek is broken.

Some smart hacker added an optimization in there to avoid seeks to
odd addresses, but that code is wrong when the file is fopened for reading
and writing.

The effect is that if your 'm' or 'y' in the active file is at an odd
address the code will not work. Typical phase of the moon behaviour
at first sight.

So if you are running 4.1BSD I suggest getting the source for fseek,
from /usr/src/libc/stdio/fseek.c and throwing out all the code
having to do with the resync variable.

Best wishes for '88

			Hans van Staveren
			Vrije Universiteit
			Amsterdam, Holland