chip@vector.UUCP (Chip Rosenthal) (05/31/88)
I'm having errlog messages like this from time to time:
inews: No valid newsgroups found, moved to junk
inews: rnews failed, status 256. Batch saved in /usr/spool/news/88053017024b34
inews: No valid newsgroups found, moved to junk
inews: rnews failed, status 256. Batch saved in /usr/spool/news/88053017024b36
This is because somebody slipped some comp.binaries.whatever drivel to
me, which is blacklisted in both my sys and active files. I'm running
2.11 patchlevel 8 mongrelized for XENIX. SPOOLNEWS is enabled.
This junk should be moved to junk. But, I don't need it saved a second time
as a "failed batch". I've traced this down to "insert()" in inews.c. I
want to change the last line from:
xxit((mode == PROC && filename[0] == '\0') ? 0 :
(exitcode < 0 ? 0 : exitcode));
to:
xxit(0);
I won't make this hack if either somebody can convince me this is wrong, or
comp.binaries.all is nuked. Any takers?
--
Chip Rosenthal /// chip@vector.UUCP /// Dallas Semiconductor /// 214-450-0400
{uunet!warble,sun!texsun!rpp386,killer}!vector!chip
I won't sing for politicians. Ain't singing for Spuds. This note's for you.jos@philapd.UUCP (Jos Vos) (06/01/88)
In article <332@vector.UUCP> chip@vector.UUCP (Chip Rosenthal) writes: >I'm having errlog messages like this from time to time: > > inews: No valid newsgroups found, moved to junk > inews: rnews failed, status 256. Batch saved in /usr/spool/news/88053017024b34 I was just planning to post a similar message! I'm running 2.11 patchlevel 14 (!) (Philips P9000 System V UNIX) and I have the same behaviour. A few weeks ago I started with "official" sources, so I'm sure it's not due to a special version of the code. The patch I put in just this morning was: - Introduce a new variable "exitorig" (as alternative for "exitcode"). - Initialize this to 0. - Don't set "exitcode" to 1 in case of invalid newsgroups, orphaned response or out-of-date article, but set "exitorig" to 1 ("exitcode" stays 0). - In line 1115 (if (exitcode == 0) { if (vflag) ...) replace "exitcode == 0" with "exitcode == 0 && exitorig == 0". This works fine and I think it's more safe the Chip's solution. I first tried not to set exitcode in the 3 cases, but then the article was put two times in the history file. I'm sure the 256 (1 << 8) is the "exitcode = 1" statement, because I replaced the 1,1,1 by 2,3,4 (in the 3 cases) and then got 512 (2 << 8) on an invalid newsgroup. Of course, I'm also waiting for the definite answer... -- # Jos Vos # Internet jos@philapd.UUCP # # Philips TDS, Dept SSP # # # P.O. Box 245 # UUCP ..!mcvax!philapd!jos # # 7300 AE Apeldoorn, The Netherlands # Phone +31 55 433181 #