[news.software.b] addmissing dies with assert in histslash

russell@ccu1.aukuni.ac.nz (Russell J Fulton;ccc032u) (02/07/91)

When I run addmissing I get the following message (after about an hours cpu 
time has been used).

Assertion failed: last != NULL, file histslash.c, line 29
/usr/lib/newsbin/maint/addmissing: 3549 abort - core dumped

From the source of histslash I have worked out that this happens when it
is feed a blank or null line.  Input to histslash comes from comm of
the list of articles on disk and list of articles in the history file ---
why this should have blank lines in it is beyond me. (It shouldn't ofcourse
thats why its crashing!!) 

Would it be safe to alter histslash to ignore blank lines rather than give up?

(By ignore I mean filter them out.)

Thanks Russell.
-- 
Russell Fulton, Computer Center, University of Auckland, New Zealand.
<rj_fulton@aukuni.ac.nz>

henry@zoo.toronto.edu (Henry Spencer) (02/07/91)

In article <1991Feb7.010455.1634@ccu1.aukuni.ac.nz> russell@ccu1.aukuni.ac.nz (Russell J Fulton;ccc032u) writes:
>From the source of histslash I have worked out that this happens when it
>is feed a blank or null line.  Input to histslash comes from comm of
>the list of articles on disk and list of articles in the history file ---
>why this should have blank lines in it is beyond me...

It's a bug in histdups, the previous stage of the pipeline.  You get the
blank line if there are no missing articles at all.  It will be fixed in
the next patch.  For the moment, it's pretty harmless, except for that
annoying message and core dump.

Sigh, the perils of trying to do thorough testing...  Addmissing is
relatively costly to test, and the one all-up test I ran *did* find a
couple of missing articles, the aftermath of a months-previous crash.
-- 
"Maybe we should tell the truth?"      | Henry Spencer at U of Toronto Zoology
"Surely we aren't that desperate yet." |  henry@zoo.toronto.edu   utzoo!henry