[net.micro.mac] Rascal Library fixes

dubois@uwmacc.UUCP (Paul DuBois) (06/10/86)

Here's some things Rascal programmers might like to fix in their
libraries.

in uToolIntf:

The KeyMap type is defined as Byte[8].  Should be Byte[16].  Guaranteed
to crash otherwise.

in __DeskLib:

The GetResIDBase function has a line that says

	if !IsDARun then ...

Since IsDARun is a function, one wants to test its value, not its
address.  Replace with

	if !IsDARun () then ...

in __ToolLink:

TEFromScrap has a line that says

	L := GetScrap (TEScrapHandle(), ptrl (" TEXT"+2)^, 0L);

That "0L" parameter is supposed to be the address of a long variable,
into which an offset is placed.  0L will work, coincidentally, but
isn't really correct.  It will also mess up techniques such as early
detection of nil pointers by placing -1L at address zero (this is used,
e.g., in some of the Skels posted to the net a while back).

Fix:  declare a LongInt variable offset, change above line to:

	L := GetScrap (TEScrapHandle(), ptrl (" TEXT"+2)^, @offset);
-- 
Paul DuBois     UUCP: {allegra,ihnp4,seismo}!uwvax!uwmacc!dubois    |
                ARPA: dubois@easter                               --+--
                                                                    |
Doth the hawk fly by thy wisdom, and stretch her wings              |
toward the south?                        Job 39:26

maclab@reed.UUCP (Mac DLab) (06/13/86)

> Here's some things Rascal programmers might like to fix in their
> libraries....
> 
>   ....
>
> Paul DuBois    

Thanks Paul, for those library corrections. 

Thought I might mention, while we're on the subject, that there will be
a new Rascal release coming in the next couple of months.  This release
will consist mostly of bug fixes, library fixes, and some new stuff, too.  

If you have ideas as to what you would like to see in this release,
please send your suggestions to me (soon).

Scott Gillespie
Reed College