brad@gcc-milo.ARPA (Brad Parker) (03/31/86)
References:
During a marathon port session of rnews code (don't ask), I discovered
that "getfield" in header.c does a (looks like) bad thing.
If I'm not mistaken, several of the fields filled in by
getfield are not "BUFLEN" length (they are shorter).
code fragment:
getfield(hpfield)
char *hpfield;
{
...
if (*ptr != '\0') {
strncpy(hpfield, ptr, BUFLEN);
nstrip(hpfield);
}
...
}
I changed the "strncpy" to a "strcpy" and it seems to work. Why
use "strncpy"? Are we worried about binary in the news lines? (seems
unlikely). "nstrip" does nice things to the ascii anyway.
-If this is fixed in 2.10.3, then "never mind". If not,
consider this a bug report.
ps: I think there should be more #ifdefs in the news code.
(non-news people: this is a MAJOR news subcult oriented joke.
All news hackers should be laughing on the floor at this point ;-) )
-brad
--
J Bradford Parker
General Computer (HyperDrive Beach)
harvard!gcc-milo!brad
"She said, 'Just drive.'" -heard on the radio.