[net.bugs.usg] bug in libcurses.a

rrw@ccice1.UUCP (Rick Wessman) (10/07/85)

There is a bug in the "getsh" function in the setupterm.c module
that affects machines whose characters are signed. In fact, "pg"
will dump core every time with this bug.

VAXes and PDP-11 don't have this problem, because they use a define
instead of the function.

Ironically, the comment before the function states that this
function works on machines that have sign extension.

Here are the diffs:
*** setupterm.c	Mon Jul  1 12:14:30 1985
--- setupterm.c.old	Thu Sep 19 17:19:59 1985
***************
*** 44,51
  	register int rv;
  	if (*p == 0377)
  		return -1;
! 	rv = (unsigned char) *p++;
! 	rv += (unsigned char) *p * 256;
  	return rv;
  }
  #endif
--- 44,51 -----
  	register int rv;
  	if (*p == 0377)
  		return -1;
! 	rv = *p++;
! 	rv += *p * 256;
  	return rv;
  }
  #endif


			Rick Wessman
			..!seismo!rochester!ccice5!ccice1!rrw
					or
			..!ccicpg!ccice5!ccice1!rrw