wmb@sun.uucp (Mitch Bradley) (01/09/84)
Here are a few fixes for bugs that I found when I tried to use enews. There were 2 general bugs: 1) The old "NULL pointer" incompatibility between the VAX and the 68000. Enews depended upon being able to dereference a NULL pointer. 2) Multiple-line "options" lines in .newsrc weren't handled properly. In particular, if a "-n" option list spanned several lines, only the newsgroups on the first such line were seen, unless the "-n" was repeated on each line. After having tried-out enews, I prefer rnews, because rnews offers more capabilities. Enews is quite similar to the normal readnews interface, which may attract some people who are comfortable with readnews. Personally, I don't like the readnews interface. Anyway, here is a diff listing for the bug fixes to the endex.c program. The first lines are the old, the second are the new. 351a352,353 > if (cp == (string)NULL) > return (string)NULL; 357a360 > 376a380 > int processing_newsgroups = No; 380d383 < 389,392c392,397 < if (Strequ(wp, "-n")) { < while ((wp = getword(&cp)) && wp[0] != '-') < addoption(wp); < } --- > if (Strequ(wp, "-n")) > processing_newsgroups = Yes; > else if ( wp[0] == '-' ) > processing_newsgroups = No; > else > addoption(wp); 509c514 < active[i].a_data ? active[i].a_data : ""); --- > active[i].a_data ? active[i].a_data : (string)NULL); 719c724 < if (!isdigit(*cp)) --- > if (!cp || !isdigit(*cp)) Cheers, Mitch Bradley Sun Microsystems, Inc. decvax!decwrl!sun!wmb