[net.news.b] Vnews bug: BC,UP not extern.

lee@west44.UUCP (Lee McLoughlin) (08/21/84)

The following bugs in Vnews cropped up when trying to use a B.B.C micro as
a terminal to read news on.  The Beeb is 25 * 80 and needs to output null's
in the cursor address sequence, at least the one I was using had to.
 Unfortunetly the BC and UP characters which tgoto needs in order to do this
are not extern char *'s in our virtterm.c but are #define's.

Here are the fixes I found necessary.
------
#define MAXPLEN 25	/* LMCL: was 24 */
.
.
.
#define xUP _tstr[4]		/* up one line, LMCL: added x to avoid clash */
.
.
#define xBC _tstr[9]		/* backspace, LMCL: added x to avoid clash */
.
.
extern char *UP;		/* LMCL: UP string must exist for tgoto */
extern char *BC;		/* LMCL: BC string must exist for tgoto */
.
.
.
	if (HO)
		HOlen = strlen(HO);
	else
		HOlen = 999;

	PC = xPC ? xPC[0] : 0;
	UP = xUP;		/* LMCL */
	BC = xBC;		/* LMCL */
.
.
.
---------
And change all the original occurences of UP to xUP and BC to xBC.
-- 
--------------
Lee McLoughlin	<UK>!ukc!lmcl, west44!lee
	UKUUCP support.

gregbo@hou2e.UUCP (Greg Skinner) (08/21/84)

These lines remind me of a problem I had with compiling vnews (2.10.1)
on a unix/370:


> From: lee@west44.UUCP (Lee McLoughlin)

> The following bugs in Vnews cropped up when trying to use a B.B.C micro as
> a terminal to read news on.  The Beeb is 25 * 80 and needs to output null's
> in the cursor address sequence, at least the one I was using had to.
> Unfortunetly the BC and UP characters which tgoto needs in order to do this
> are not extern char *'s in our virtterm.c but are #define's.


	PC = xPC ? xPC[0] : 0;
	UP = xUP;		/* LMCL */
	BC = xBC;		/* LMCL */

> And change all the original occurences of UP to xUP and BC to xBC.

In vnews 2.10.1 PC was declared char PC, and when I went to compile it I got
this back from ld:

ld:  symbol PC multiply defined, first occurs in virtterm.o

I fixed it by renaming PC to xPC and it compiled ok, but due to termcap troubles
and the kernel unwilling to let it go (it survives a kill -9) I'm unable to
get it running.

We run 2.10 netnews because of base register problems (hopefully fixed) with
our unix/370.  I wonder does this have anything to do with my problems.

-- 
Hug me till you drug me, honey!

Greg Skinner (gregbo)
{allegra,cbosgd,ihnp4}!hou2e!gregbo