[net.news.b] Bug in xfopen

idallen@watmath.UUCP (01/27/85)

x
	/* kludge for setuid not being honored for root */
#ifdef OLD_NONSENSE
	if ((uid == 0) && (duid != 0) && ((fmode == "a") || (fmode == "w")))
		chown(name, duid, dgid);
#else  CORRECT
	if ((uid == 0) && (duid != 0)
	    && (strcmp(fmode,"a")==0 || strcmp(fmode,"w")==0))
		chown(name, duid, dgid);
#endif
	return(fp);

Methinks someone thought C had string operators.

msb@lsuc.UUCP (Mark Brader) (01/28/85)

xfopen() does indeed contain the stated bug (attempts to compare
strings using ==), but you won't find it in rfuncs.c; funcs.c is
the file it's in.

Mark Brader